xfs
[Top] [All Lists]

Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided
From: Lukáš Czerner <lczerner@xxxxxxxxxx>
Date: Tue, 12 Feb 2013 16:37:37 +0100 (CET)
Cc: Lukas Czerner <lczerner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <511A5BAA.5000203@xxxxxxxxxxx>
References: <1360670381-19838-1-git-send-email-lczerner@xxxxxxxxxx> <511A5BAA.5000203@xxxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Tue, 12 Feb 2013, Eric Sandeen wrote:

> Date: Tue, 12 Feb 2013 09:11:38 -0600
> From: Eric Sandeen <sandeen@xxxxxxxxxxx>
> To: Lukas Czerner <lczerner@xxxxxxxxxx>
> Cc: xfs@xxxxxxxxxxx
> Subject: Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided
> 
> On 2/12/13 5:59 AM, Lukas Czerner wrote:
> > When '-N' is specified we really should not write anything to the
> > device, neither we should attempt to discard the device.
> > 
> > This commit fixes xfs_mkfs to not attempt to discard the device in the
> > case user specified '-N' flag.
> 
> Thanks, and yes - ouch, this shouldn't happen with -N, that's bad!
> 
> But it doesn't look like this is against the current git tree,
> it applies only with a lot of fuzz & offsets.

Ah, I've been using 

git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git

and I can remember that it's not the first time I've realized that I
am using wrong repo. Obviously i am not paying a lot of attention to
the xfs channel, but does this keep changing, or is it just me ? :)

Will resend the patch based on the

git://oss.sgi.com/xfs/cmds/xfsprogs.git

thanks Eric!

-Lukas

> 
> -Eric
> 
> > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> > ---
> >  mkfs/xfs_mkfs.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> > index a889620..95e27e0 100644
> > --- a/mkfs/xfs_mkfs.c
> > +++ b/mkfs/xfs_mkfs.c
> > @@ -2010,7 +2010,7 @@ _("block size %d cannot be smaller than logical 
> > sector size %d\n"),
> >                     exit(1);
> >             }
> >  
> > -   if (discard) {
> > +   if (discard && !Nflag) {
> >             discard_blocks(xi.ddev, xi.dsize);
> >             if (xi.rtdev)
> >                     discard_blocks(xi.rtdev, xi.rtsize);
> > 
> 
> 

<Prev in Thread] Current Thread [Next in Thread>