xfs
[Top] [All Lists]

Re: [PATCH v4 2/2] xfs: remove log force from xfs_buf_trylock()

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v4 2/2] xfs: remove log force from xfs_buf_trylock()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Feb 2013 08:53:24 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1360595302-15865-3-git-send-email-bfoster@xxxxxxxxxx>
References: <1360595302-15865-1-git-send-email-bfoster@xxxxxxxxxx> <1360595302-15865-3-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 11, 2013 at 10:08:22AM -0500, Brian Foster wrote:
> The trylock log force invoked via xfs_buf_item_push() can attempt
> to acquire xa_lock, thus leading to a recursion bug when called
> with xa_lock held.
> 
> This log force was originally added to xfs_buf_trylock() to address
> xfsaild stalls due to pinned and stale buffers. Since the addition
> of this behavior, the log item pushing code had been reworked to
> detect and track pinned items to inform xfsaild to issue a log
> force itself when necessary. As such, the log force on trylock
> failure is redundant and safe to remove.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>