[Top] [All Lists]

[PATCH v4 0/2] fix spinlock recursion on xa_lock in xfs_buf_item_push

To: xfs@xxxxxxxxxxx
Subject: [PATCH v4 0/2] fix spinlock recursion on xa_lock in xfs_buf_item_push
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 11 Feb 2013 10:08:20 -0500
Delivered-to: xfs@xxxxxxxxxxx
Hi all,

Here is v4 of the spinlock recursion fix. The only update is to the comment in
patch 1. These changes have been run through the reproducer over the weekend
without a failure.

I've also run another xfstests run while including the following patch from 

xfs: xfs_bmap_add_attrfork_local is too generic

... due to seeing the same issue Lukas reproduced in test 013 (I saw it in 070 
well). That problem no longer occurs with this patch included, but I have hit
an error in test 178 that didn't fire in my baseline run. It persists if I 
back to TOT, so I'm posting this set as is and I'll see if I can trace where 
one came from...


- Fix comment in patch 1.
- Patches reordered and revised to:
  1.) Add the race detection in xfs_buf_item_push().
  2.) Remove the log force from xfs_buf_trylock() entirely to fix the recursion
      and rely on xfsaild to issue the log force.
- Patch 2 is reworked to detect the potential race and defer the log force to
  xfsaild by returning XFS_ITEM_PINNED.

Brian Foster (2):
  xfs: recheck buffer pinned status after push trylock failure
  xfs: remove log force from xfs_buf_trylock()

 fs/xfs/xfs_buf.c      |    2 --
 fs/xfs/xfs_buf_item.c |   12 +++++++++++-
 2 files changed, 11 insertions(+), 3 deletions(-)


<Prev in Thread] Current Thread [Next in Thread>