xfs
[Top] [All Lists]

Re: Xfs fails in xfstests 013

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: Xfs fails in xfstests 013
From: Lukáš Czerner <lczerner@xxxxxxxxxx>
Date: Mon, 11 Feb 2013 13:08:12 +0100 (CET)
Cc: Lukáš Czerner <lczerner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130210221600.GC8257@dastard>
References: <alpine.LFD.2.00.1301310910080.14328@xxxxxxxxxxxxxxxxxxxxxxxxx> <20130201002927.GJ32297@xxxxxxxxxxxxxxxxxx> <alpine.LFD.2.00.1302011149030.6969@xxxxxxxxxxxxxxxxxxxxxxxxx> <alpine.LFD.2.00.1302011219300.6969@xxxxxxxxxxxxxxxxxxxxxxxxx> <20130203230013.GI2667@dastard> <20130210221600.GC8257@dastard>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Mon, 11 Feb 2013, Dave Chinner wrote:

> Date: Mon, 11 Feb 2013 09:16:00 +1100
> From: Dave Chinner <david@xxxxxxxxxxxxx>
> To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
> Cc: xfs@xxxxxxxxxxx
> Subject: Re: Xfs fails in xfstests 013
> 
> On Mon, Feb 04, 2013 at 10:00:13AM +1100, Dave Chinner wrote:
> > On Fri, Feb 01, 2013 at 03:33:06PM +0100, LukÃÅ Czerner wrote:
> > > On Fri, 1 Feb 2013, LukÃÅ Czerner wrote:
> > > and I have not hit the assert. However I think that I know what's
> > > going on. The verifier is obviously not attached when the symlink is
> > > created, however it is attached when security attributes are created
> > > for the symlink by xfs_init_security().
> > 
> > Which means the bug is in xfs_bmap_add_attrfork_local() in calling
> > xfs_bmap_local_to_extents(). i.e it assumes that the local data is
> > either directory data or extent data, and is attaching extent tree
> > verifiers to the buffer that contains a remote symlink. Thinking
> > time now needed, as this affects the symlink CRC changes as well.
> > 
> > Thanks for the debug help, Lukas.
> 
> Lukas, can you check whether the patch below fixes the problem you
> saw?

Hi Dave,

from my testing it seems that ti fixes the problem. Can not
reproduce it anymore with the patch applied.

Thanks!
-Lukas

> 
> Cheers,
> 
> Dave.
> 
<Prev in Thread] Current Thread [Next in Thread>