[Top] [All Lists]

[PATCH v3 0/2] fix spinlock recursion on xa_lock in xfs_buf_item_push

To: xfs@xxxxxxxxxxx
Subject: [PATCH v3 0/2] fix spinlock recursion on xa_lock in xfs_buf_item_push
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Fri, 8 Feb 2013 09:51:05 -0500
Delivered-to: xfs@xxxxxxxxxxx
Hi all,

Here is v3 of the spinlock recursion fix, based on Dave's comments here:


Note that I'm testing and posting this for review in parallel, given that v2
had seen several hours of testing with the log force bypassed in aild context.
This implementation removes the trylock log force entirely, so continued testing
will determine whether any regressions crop up and I'll post an update after a
few days.


- Patches reordered and revised to:
  1.) Add the race detection in xfs_buf_item_push().
  2.) Remove the log force from xfs_buf_trylock() entirely to fix the recursion
      and rely on xfsaild to issue the log force.
- Patch 2 is reworked to detect the potential race and defer the log force to
  xfsaild by returning XFS_ITEM_PINNED.

Brian Foster (2):
  xfs: recheck buffer pinned status after push trylock failure
  xfs: remove log force from xfs_buf_trylock()

 fs/xfs/xfs_buf.c      |    2 --
 fs/xfs/xfs_buf_item.c |    9 ++++++++-
 2 files changed, 8 insertions(+), 3 deletions(-)


<Prev in Thread] Current Thread [Next in Thread>