| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 1/2] xfs: conditionally force log on trylock failure of pinned/stale buf |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Wed, 06 Feb 2013 14:24:43 -0600 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1360154681-28246-2-git-send-email-bfoster@xxxxxxxxxx> |
| References: | <1360154681-28246-1-git-send-email-bfoster@xxxxxxxxxx> <1360154681-28246-2-git-send-email-bfoster@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 02/06/13 06:44, Brian Foster wrote: xfs_force_log() is not safe from all contexts. Add a flag parameter to xfs_buf_trylock() to specify when the force is appropriate and create a macro to preserve current behavior. Signed-off-by: Brian Foster<bfoster@xxxxxxxxxx> --- fs/xfs/xfs_buf.c | 8 +++++--- fs/xfs/xfs_buf.h | 3 ++- 2 files changed, 7 insertions(+), 4 deletions(-) Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 0/4] Refactor release scripts to conform to using git?archive, Ben Myers |
|---|---|
| Next by Date: | Re: [PATCH v2 2/2] xfs: disable log force in xfs_buf_item_push() to avoid xa_lock recursion, Mark Tinguely |
| Previous by Thread: | [PATCH v2 1/2] xfs: conditionally force log on trylock failure of pinned/stale buf, Brian Foster |
| Next by Thread: | Re: [PATCH v2 1/2] xfs: conditionally force log on trylock failure of pinned/stale buf, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |