xfs
[Top] [All Lists]

Re: [PATCH 0/4] Refactor release scripts to conform to using git archive

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 0/4] Refactor release scripts to conform to using git archive
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 6 Feb 2013 12:15:47 +1100
Cc: Andrew Dahl <adahl@xxxxxxx>, xfs@xxxxxxxxxxx, nathans@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130201190930.GX27055@xxxxxxx>
References: <50F44B2E.9050408@xxxxxxx> <20130201190930.GX27055@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 01, 2013 at 01:09:30PM -0600, Ben Myers wrote:
> On Mon, Jan 14, 2013 at 12:15:10PM -0600, Andrew Dahl wrote:
> > The following four patches fix an issue seen during the last user space
> > release where not all source files were included in xfsprogs.  They each
> > change xfsprogs, xfstests, xfsdump, and dmapi to all use git archive for
> > source tarball generation and add 'make realclean' in the release
> > scripts to ensure the configure and m4/autotools temp files are refreshed.
> 
> Applied this series.

It breaks the 'make deb' command for all the trees.

The debian package build creates a link tree so that it builds
outside the main source tree (e.g. in ./xfsprogs-3.1.10) and as part
of the build it runs 'make dist' to build a tarball from that link
tree. That now fails with:

fatal: current working directory is untracked

coming from the git archive command that is now used to build the
tarball.

Nathan, can the debian package build use git-archive? I'm under the
impression that you have to be able to build debian packages from a
source tarball or a source package, and so the build can't rely on
being inside a VCS controlled tree. That rules out using git archive
for tarball creation...

Also, given that the previous tarball creation used the same link
tree build as the debian package build (i.e. make source-link), that
implies the debian pacakges are going to be missing files using this
technique. Doesn't that mean we have to fix the file list being fed
into the source-link target regardless of whether we use git archive
to build the tarball?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>