xfs
[Top] [All Lists]

[PATCH 65/93] xfs: Fix possible use-after-free with AIO

To: linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, kernel-team@xxxxxxxxxxxxxxxx
Subject: [PATCH 65/93] xfs: Fix possible use-after-free with AIO
From: Herton Ronaldo Krzesinski <herton.krzesinski@xxxxxxxxxxxxx>
Date: Tue, 5 Feb 2013 20:06:54 -0200
Cc: xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>, Jan Kara <jack@xxxxxxx>, Herton Ronaldo Krzesinski <herton.krzesinski@xxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1360102042-10732-1-git-send-email-herton.krzesinski@xxxxxxxxxxxxx>
References: <1360102042-10732-1-git-send-email-herton.krzesinski@xxxxxxxxxxxxx>
3.5.7.5 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Jan Kara <jack@xxxxxxx>

commit 4b05d09c18d9aa62d2e7fb4b057f54e5a38963f5 upstream.

Running AIO is pinning inode in memory using file reference. Once AIO
is completed using aio_complete(), file reference is put and inode can
be freed from memory. So we have to be sure that calling aio_complete()
is the last thing we do with the inode.

CC: xfs@xxxxxxxxxxx
CC: Ben Myers <bpm@xxxxxxx>
Signed-off-by: Jan Kara <jack@xxxxxxx>
Reviewed-by: Ben Myers <bpm@xxxxxxx>
Signed-off-by: Ben Myers <bpm@xxxxxxx>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@xxxxxxxxxxxxx>
---
 fs/xfs/xfs_aops.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 8dad722..6868548 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -86,11 +86,11 @@ xfs_destroy_ioend(
        }
 
        if (ioend->io_iocb) {
+               inode_dio_done(ioend->io_inode);
                if (ioend->io_isasync) {
                        aio_complete(ioend->io_iocb, ioend->io_error ?
                                        ioend->io_error : ioend->io_result, 0);
                }
-               inode_dio_done(ioend->io_inode);
        }
 
        mempool_free(ioend, xfs_ioend_pool);
-- 
1.7.9.5

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 65/93] xfs: Fix possible use-after-free with AIO, Herton Ronaldo Krzesinski <=