xfs
[Top] [All Lists]

Re: [PATCH 10/18] mm: teach truncate_inode_pages_range() to handle non p

To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges
From: Lukáš Czerner <lczerner@xxxxxxxxxx>
Date: Tue, 5 Feb 2013 08:14:51 +0100 (CET)
Cc: Lukáš Czerner <lczerner@xxxxxxxxxx>, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Hugh Dickins <hughd@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130204125136.b0926f20.akpm@xxxxxxxxxxxxxxxxxxxx>
References: <1359715424-32318-1-git-send-email-lczerner@xxxxxxxxxx> <1359715424-32318-11-git-send-email-lczerner@xxxxxxxxxx> <20130201151502.59398b29.akpm@xxxxxxxxxxxxxxxxxxxx> <alpine.LFD.2.00.1302041510090.3225@localhost> <20130204125136.b0926f20.akpm@xxxxxxxxxxxxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Mon, 4 Feb 2013, Andrew Morton wrote:

> Date: Mon, 4 Feb 2013 12:51:36 -0800
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> To: Lukáš Czerner <lczerner@xxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
>     linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx,
>     xfs@xxxxxxxxxxx, Hugh Dickins <hughd@xxxxxxxxxx>
> Subject: Re: [PATCH 10/18] mm: teach truncate_inode_pages_range() to handle
>     non page aligned ranges
> 
> On Mon, 4 Feb 2013 15:51:19 +0100 (CET)
> Luk____ Czerner <lczerner@xxxxxxxxxx> wrote:
> 
> > I hope I explained myself well enough :). Are you ok with this king
> > of approach ? If so, I'll resend the patch set without the
> > initialisation-at-declaration.
> 
> uh, maybe.  Next time I'll apply the patch and look at the end result! 
> Try to make it as understandable and (hence) maintainable as possible,
> OK?

Agreed.

Thanks!
-Lukas
<Prev in Thread] Current Thread [Next in Thread>