xfs
[Top] [All Lists]

Re: [PATCH 10/18] mm: teach truncate_inode_pages_range() to handle non p

To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges
From: Lukáš Czerner <lczerner@xxxxxxxxxx>
Date: Mon, 4 Feb 2013 15:51:19 +0100 (CET)
Cc: Lukas Czerner <lczerner@xxxxxxxxxx>, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Hugh Dickins <hughd@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130201151502.59398b29.akpm@xxxxxxxxxxxxxxxxxxxx>
References: <1359715424-32318-1-git-send-email-lczerner@xxxxxxxxxx> <1359715424-32318-11-git-send-email-lczerner@xxxxxxxxxx> <20130201151502.59398b29.akpm@xxxxxxxxxxxxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Fri, 1 Feb 2013, Andrew Morton wrote:

> Date: Fri, 1 Feb 2013 15:15:02 -0800
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> To: Lukas Czerner <lczerner@xxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
>     linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx,
>     xfs@xxxxxxxxxxx, Hugh Dickins <hughd@xxxxxxxxxx>
> Subject: Re: [PATCH 10/18] mm: teach truncate_inode_pages_range() to handle
>     non page aligned ranges
> 
> On Fri,  1 Feb 2013 11:43:36 +0100
> Lukas Czerner <lczerner@xxxxxxxxxx> wrote:
> 
> > This commit changes truncate_inode_pages_range() so it can handle non
> > page aligned regions of the truncate. Currently we can hit BUG_ON when
> > the end of the range is not page aligned, but we can handle unaligned
> > start of the range.
> > 
> > Being able to handle non page aligned regions of the page can help file
> > system punch_hole implementations and save some work, because once we're
> > holding the page we might as well deal with it right away.
> > 
> > In previous commits we've changed ->invalidatepage() prototype to accept
> > 'length' argument to be able to specify range to invalidate. No we can
> > use that new ability in truncate_inode_pages_range().
> 
> The change seems sensible.
> 
> > This was based on the code provided by Hugh Dickins
> 
> Despite this ;)
> 
> > changes to make use of do_invalidatepage_range().
> >
> > ...
> >
> >  void truncate_inode_pages_range(struct address_space *mapping,
> >                             loff_t lstart, loff_t lend)
> >  {
> > -   const pgoff_t start = (lstart + PAGE_CACHE_SIZE-1) >> PAGE_CACHE_SHIFT;
> > -   const unsigned partial = lstart & (PAGE_CACHE_SIZE - 1);
> > +   pgoff_t start = (lstart + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
> > +   pgoff_t end = (lend + 1) >> PAGE_CACHE_SHIFT;
> > +   unsigned int partial_start = lstart & (PAGE_CACHE_SIZE - 1);
> > +   unsigned int partial_end = (lend + 1) & (PAGE_CACHE_SIZE - 1);
> >     struct pagevec pvec;
> >     pgoff_t index;
> > -   pgoff_t end;
> >     int i;
> 
> This is starting to get pretty hairy.  Some of these "end" variables
> are inclusive and some are exclusive.

Yes, I agree that it's little bit confusing.

> 
> Can we improve things?  We can drop all this tiresome
> intialisation-at-declaration-site stuff and do:

Yes, I agree that this will make things cleaner.

> 
>       pgoff_t start;                  /* inclusive */
>       pgoff_t end;                    /* exclusive */
>       unsigned int partial_start;     /* inclusive */
>       unsigned int partial_end;       /* exclusive */
>       struct pagevec pvec;
>       pgoff_t index;
>       int i;
> 
>       start = (lstart + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
>       end = (lend + 1) >> PAGE_CACHE_SHIFT;
>       partial_start = lstart & (PAGE_CACHE_SIZE - 1);
>       partial_end = (lend + 1) & (PAGE_CACHE_SIZE - 1);
> 
> And lo, I see that the "inclusive" thing only applies to incoming arg
> `lend'.  I seem to recall that being my handiwork and somehow I seem to
> not have documented the reason: it was so that we can pass
> lend=0xffffffff into truncate_inode_pages_range) to indicate "end of
> file".
> 
> Your code handles this in a rather nasty fashion.  It permits the above
> overflow to occur then later fixes it up with an explicit test for -1. 
> And it then sets `end' (which is a pgoff_t!) to -1.
> 
> I guess this works, but let's make it clearer, with something like:
> 
>       if (lend == -1) {
>               /*
>                * Nice explanation goes here
>                */
>               end = -1;
>       } else {
>               end = (lend + 1) >> PAGE_CACHE_SHIFT;
>       }

Good point, this is better.

> 
> 
> >     cleancache_invalidate_inode(mapping);
> >     if (mapping->nrpages == 0)
> >             return;
> >  
> > -   BUG_ON((lend & (PAGE_CACHE_SIZE - 1)) != (PAGE_CACHE_SIZE - 1));
> > -   end = (lend >> PAGE_CACHE_SHIFT);
> > +   if (lend == -1)
> > +           end = -1;       /* unsigned, so actually very big */
> >  
> >     pagevec_init(&pvec, 0);
> >     index = start;
> > -   while (index <= end && pagevec_lookup(&pvec, mapping, index,
> > -                   min(end - index, (pgoff_t)PAGEVEC_SIZE - 1) + 1)) {
> > +   while (index < end && pagevec_lookup(&pvec, mapping, index,
> > +                   min(end - index, (pgoff_t)PAGEVEC_SIZE))) {
> 
> Here, my brain burst.  You've effectively added 1 to (end - index).  Is
> that correct?

Not sure what do you mean by that. I have to admit that I've changed
the 'end' variable from previous inclusive to exclusive for two
reasons. First of all it makes more sense to me and second of all it
solves the pain where we're dealing with the partial truncation within
the first page.

> 
> >             mem_cgroup_uncharge_start();
> >             for (i = 0; i < pagevec_count(&pvec); i++) {
> >                     struct page *page = pvec.pages[i];
> >  
> >                     /* We rely upon deletion not changing page->index */
> >                     index = page->index;
> > -                   if (index > end)
> > +                   if (index >= end)
> 
> hm.  This change implies that the patch changed `end' from inclusive to
> exclusive.  But the patch didn't do that.

Yes, the patch is doing exactly that, but I should have documented I
guess, sorry about that...

> 
> >                             break;
> >  
> >                     if (!trylock_page(page))
> > @@ -250,27 +247,51 @@ void truncate_inode_pages_range(struct address_space 
> > *mapping,
> >             index++;
> >     }
> >  
> > -   if (partial) {
> > +   if (partial_start) {
> >             struct page *page = find_lock_page(mapping, start - 1);
> >             if (page) {
> > +                   unsigned int top = PAGE_CACHE_SIZE;
> > +                   if (start > end) {
> 
> How can this be true?

It can in the case that we're dealing with partial truncation within the
single page. Because 'start' and 'end' covers only the full pages.
Partial pages are covered with 'partial_start' and 'partial_end' and
it is obvious which page it is.. either the one before start or/and the
one at the 'end'.


> 
> > +                           top = partial_end;
> > +                           partial_end = 0;
> > +                   }
> > +                   wait_on_page_writeback(page);
> > +                   zero_user_segment(page, partial_start, top);
> > +                   cleancache_invalidate_page(mapping, page);
> > +                   if (page_has_private(page))
> > +                           do_invalidatepage(page, partial_start,
> > +                                             top - partial_start);
> > +                   unlock_page(page);
> > +                   page_cache_release(page);
> > +           }
> > +   }
> > +   if (partial_end) {
> > +           struct page *page = find_lock_page(mapping, end);
> > +           if (page) {
> >                     wait_on_page_writeback(page);
> > -                   truncate_partial_page(page, partial);
> > +                   zero_user_segment(page, 0, partial_end);
> > +                   cleancache_invalidate_page(mapping, page);
> > +                   if (page_has_private(page))
> > +                           do_invalidatepage(page, 0,
> > +                                             partial_end);
> >                     unlock_page(page);
> >                     page_cache_release(page);
> >             }
> >     }
> > +   if (start >= end)
> > +           return;
> 
> Again, how can start be greater than end??
> 
> I suspect a lot of the confustion and churn in here is due to `end'
> being kinda-exclusive.  If `lend' was 4094 then `end' is zero.  But if
> `lend' was 4095' then `end' is 1.  So even though `end' refers to the same
> page, it has a different value!

As I mentioned above 'start' and 'end' covers only full pages.
Partial pages are outside the range and those are covered by the
'partial_start' and 'partial_end' variables. Also as you mentioned
'lend' is inclusive.

That said, in your example 'end' does not refer to the same page,
because if 'lend' is 4094 we have a partial truncate (and start-end
does not cover that) and if 'lend' is 4096 we have a full page
truncate (assuming that 'start' is zero) so we cover the whole range
with 'end' being exclusive.

> 
> Would the code be simpler and clearer if we were to make `end' "pgoff_t
> of the last-affected page", and document it as such?
> 

I am not sure about this. It make better sense to me with 'start'
and 'end' covering the range of fully truncated pages with 'end'
being of course exclusive.

I hope I explained myself well enough :). Are you ok with this king
of approach ? If so, I'll resend the patch set without the
initialisation-at-declaration.

Thanks!
-Lukas

<Prev in Thread] Current Thread [Next in Thread>