[Top] [All Lists]

Re: Xfs fails in xfstests 013

To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
Subject: Re: Xfs fails in xfstests 013
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 4 Feb 2013 10:00:13 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <alpine.LFD.2.00.1302011219300.6969@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <alpine.LFD.2.00.1301310910080.14328@xxxxxxxxxxxxxxxxxxxxxxxxx> <20130201002927.GJ32297@xxxxxxxxxxxxxxxxxx> <alpine.LFD.2.00.1302011149030.6969@xxxxxxxxxxxxxxxxxxxxxxxxx> <alpine.LFD.2.00.1302011219300.6969@xxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 01, 2013 at 03:33:06PM +0100, LukÃÅ Czerner wrote:
> On Fri, 1 Feb 2013, LukÃÅ Czerner wrote:
> and I have not hit the assert. However I think that I know what's
> going on. The verifier is obviously not attached when the symlink is
> created, however it is attached when security attributes are created
> for the symlink by xfs_init_security().

Which means the bug is in xfs_bmap_add_attrfork_local() in calling
xfs_bmap_local_to_extents(). i.e it assumes that the local data is
either directory data or extent data, and is attaching extent tree
verifiers to the buffer that contains a remote symlink. Thinking
time now needed, as this affects the symlink CRC changes as well.

Thanks for the debug help, Lukas.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>