xfs
[Top] [All Lists]

Re: xfsprogs: fix warning in libxcmd/input.c

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: xfsprogs: fix warning in libxcmd/input.c
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 01 Feb 2013 15:43:55 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130201213649.GM30652@xxxxxxx>
References: <20130201213649.GM30652@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/01/13 15:36, Ben Myers wrote:
Fix an error when building with -Werror=format-security.

input.c: In function 'fetchline':
input.c:91:2: error: format not a string literal and no format arguments 
[-Werror=format-security]

Signed-off-by: Ben Myers<bpm@xxxxxxx>
Reported by: Arkadiusz MiÅkiewicz<arekm@xxxxxxxx>
Index: xfsprogs/libxcmd/input.c
===================================================================
--- xfsprogs.orig/libxcmd/input.c       2013-02-01 15:29:47.069894522 -0600
+++ xfsprogs/libxcmd/input.c    2013-02-01 15:30:00.845895188 -0600
@@ -88,7 +88,7 @@

        if (!line)
                return NULL;
-       printf(get_prompt());
+       printf("%s", get_prompt());
        fflush(stdout);
        if (!fgets(line, MAXREADLINESZ, stdin)) {
                free(line);

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>