[Top] [All Lists]

[PATCH 2/4] xfs: Fix possible use-after-free with AIO

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject: [PATCH 2/4] xfs: Fix possible use-after-free with AIO
From: Jan Kara <jack@xxxxxxx>
Date: Wed, 30 Jan 2013 00:27:59 +0100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx>, Ben Myers <bpm@xxxxxxx>, stable@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1359502081-20240-1-git-send-email-jack@xxxxxxx>
References: <1359502081-20240-1-git-send-email-jack@xxxxxxx>
Running AIO is pinning inode in memory using file reference. Once AIO
is completed using aio_complete(), file reference is put and inode can
be freed from memory. So we have to be sure that calling aio_complete()
is the last thing we do with the inode.

CC: xfs@xxxxxxxxxxx
CC: Ben Myers <bpm@xxxxxxx>
CC: stable@xxxxxxxxxxxxxxx
Reviewed-by: Ben Myers <bpm@xxxxxxx>
Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
Signed-off-by: Jan Kara <jack@xxxxxxx>
 fs/xfs/xfs_aops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 4111a40..5f707e5 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -86,11 +86,11 @@ xfs_destroy_ioend(
        if (ioend->io_iocb) {
+               inode_dio_done(ioend->io_inode);
                if (ioend->io_isasync) {
                        aio_complete(ioend->io_iocb, ioend->io_error ?
                                        ioend->io_error : ioend->io_result, 0);
-               inode_dio_done(ioend->io_inode);
        mempool_free(ioend, xfs_ioend_pool);

<Prev in Thread] Current Thread [Next in Thread>