xfs
[Top] [All Lists]

Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures

To: Eric Sandeen <esandeen@xxxxxxxxxx>
Subject: Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 29 Jan 2013 12:49:18 -0600
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <FE50BC18-140F-43E6-848A-EE4C9B79C9FC@xxxxxxxxxx>
References: <1359240032-11576-1-git-send-email-sandeen@xxxxxxxxxx> <1359240032-11576-3-git-send-email-sandeen@xxxxxxxxxx> <20130128003542.GB16727@xxxxxxxxxxxxxxxxxx> <FE50BC18-140F-43E6-848A-EE4C9B79C9FC@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey,

On Sun, Jan 27, 2013 at 09:41:28PM -0500, Eric Sandeen wrote:
> On Jan 27, 2013, at 8:38 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> 
> > On Sat, Jan 26, 2013 at 04:40:26PM -0600, Eric Sandeen wrote:
> >> This is a merge-to-userspace of kernel commit a0041684
> >> xfs: zero allocation_args on the kernel stack
> >> 
> >> When calling xfs_alloc_vextent args.userdata was uninitialized,
> >> and if we had args.type==XFS_ALLOCTYPE_START_BNO, this uninit
> >> structure member got tested, leading to some random allocator
> >> behavior.
> > 
> > Got that as part of the kernel-user sync I sent out a couple of
> > weeks back.
> > 
> > BTW, perhaps we want to get that sync sorted out before shovelling
> > a bunch of stuff into xfsprogs that will require fixing conflicts in
> > that sync up?
> > 
> I have no problem with this going 2nd, I can fix up as needed.

We need to do another userspace release to resolve the backward compatability
issue for Fugazzi and missing source file in xfsprogs for Arkadiusz before
shovelling in that ueber patch.  If any of these patches are bug fixes
appropriate for a release within the next week or so, give a heads up.

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>