xfs
[Top] [All Lists]

Re: [PATCH v3] xfstests 295: test xfs direct IO nested transaction deadl

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH v3] xfstests 295: test xfs direct IO nested transaction deadlock
From: Eryu Guan <eguan@xxxxxxxxxx>
Date: Tue, 29 Jan 2013 12:00:51 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1358836828-32517-1-git-send-email-eguan@xxxxxxxxxx>
References: <1358836828-32517-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jan 22, 2013 at 02:40:28PM +0800, Eryu Guan wrote:
> Regression test case for commit:
> 
> 437a255 xfs: fix direct IO nested transaction deadlock.
> 
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>

Hi, any comments on this version?

Thanks,
Eryu
> ---
> v3:
>       1. rename TESTDIR to STRESS_DIR
>       2. decrease variable by using "let"
>       3. call wait instead of sync after killing all fsstress processes
>       4. rebase on top of master
> v2:
>       1. drop generic freeze vs fsstress test, 068 has done this
>       2. remove unnecessary _scratch_unmount
>       3. rm $seq.full before _scratch_mkfs_xfs
>       4. remove unnecessary sleep
>       5. remove unnecessary output
>       6. run fixed number(10) of iterations of freeze/thaw cycles
>       7. remove from dangerous group
> 
>  295     | 88 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  295.out |  3 +++
>  group   |  1 +
>  3 files changed, 92 insertions(+)
>  create mode 100644 295
>  create mode 100644 295.out
> 
> diff --git a/295 b/295
> new file mode 100644
> index 0000000..57aa63c
> --- /dev/null
> +++ b/295
> @@ -0,0 +1,88 @@
> +#! /bin/bash
> +# FS QA Test No. 295
> +#
> +# Test freeze/unfreeze file system randomly under fsstress
> +# Regression test for commit:
> +# 437a255 xfs: fix direct IO nested transaction deadlock.
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> +#-----------------------------------------------------------------------
> +#
> +# creator
> +owner=eguan@xxxxxxxxxx
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1     # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> +    cd /
> +    rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +
> +# real QA test starts here
> +_supported_fs xfs
> +_supported_os IRIX Linux
> +
> +_require_scratch
> +_require_freeze
> +
> +rm -f $seq.full
> +_scratch_mkfs_xfs -d agcount=16,su=256k,sw=12 -l su=256k,size=2560b 
> >/dev/null 2>&1
> +_scratch_mount >/dev/null 2>&1
> +
> +STRESS_DIR="$SCRATCH_MNT/testdir"
> +mkdir -p $STRESS_DIR
> +
> +$FSSTRESS_PROG -d $STRESS_DIR -n 100 -p 1000 $FSSTRESS_AVOID >/dev/null 2>&1 
> &
> +
> +# Freeze/unfreeze file system randomly
> +echo "Start freeze/unfreeze randomly" | tee -a $seq.full
> +LOOP=10
> +while [ $LOOP -gt 0 ];do
> +     TIMEOUT=`expr $RANDOM % 5`
> +     sleep $TIMEOUT
> +     echo "* Freeze file system after sleeping $TIMEOUT seconds" >>$seq.full
> +     xfs_freeze -f $SCRATCH_MNT
> +     if [ $? -ne 0 ];then
> +             echo " - Error: freeze filesystem failed" | tee -a $seq.full
> +     fi
> +     TIMEOUT=`expr $RANDOM % 3`
> +     sleep $TIMEOUT
> +     echo "* Unfreeze file system after sleeping $TIMEOUT seconds" 
> >>$seq.full
> +     xfs_freeze -u $SCRATCH_MNT
> +     if [ $? -ne 0 ];then
> +             echo " - Error: unfreeze filesystem failed" | tee -a $seq.full
> +     fi
> +     let LOOP=$LOOP-1
> +done
> +echo "Test done" | tee -a $seq.full
> +killall -q $FSSTRESS_PROG
> +wait
> +
> +_check_scratch_fs
> +status=0
> +exit
> diff --git a/295.out b/295.out
> new file mode 100644
> index 0000000..ab4f99b
> --- /dev/null
> +++ b/295.out
> @@ -0,0 +1,3 @@
> +QA output created by 295
> +Start freeze/unfreeze randomly
> +Test done
> diff --git a/group b/group
> index 505bc7f..6578540 100644
> --- a/group
> +++ b/group
> @@ -413,3 +413,4 @@ deprecated
>  292 auto mkfs quick
>  293 auto quick
>  294 auto quick
> +295 auto freeze
> -- 
> 1.7.11.7

<Prev in Thread] Current Thread [Next in Thread>