xfs
[Top] [All Lists]

Re: [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_p

To: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>
Subject: Re: [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages()
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 28 Jan 2013 16:42:02 -0600
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130120102449.397b3f8b@xxxxxxxxxxxxxx>
References: <20130120102449.397b3f8b@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Jan 20, 2013 at 10:24:49AM +0100, Torsten Kaiser wrote:
> From: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>
> 
> Commit fb59581404ab7ec5075299065c22cb211a9262a9 removed
> xfs_flushinval_pages() and changed its callers to use
> filemap_write_and_wait() and  truncate_pagecache_range() directly.
> 
> But in xfs_swap_extents() this change accidental switched the argument
> for 'tip' to 'ip'. This patch switches it back to 'tip'
> 
> Signed-off-by: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>

Looks good.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

Thanks Torsten!

<Prev in Thread] Current Thread [Next in Thread>