xfs
[Top] [All Lists]

Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 28 Jan 2013 08:21:08 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1359240032-11576-3-git-send-email-sandeen@xxxxxxxxxx>
References: <1359240032-11576-1-git-send-email-sandeen@xxxxxxxxxx> <1359240032-11576-3-git-send-email-sandeen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 01/26/13 16:40, Eric Sandeen wrote:
This is a merge-to-userspace of kernel commit a0041684
xfs: zero allocation_args on the kernel stack

When calling xfs_alloc_vextent args.userdata was uninitialized,
and if we had args.type==XFS_ALLOCTYPE_START_BNO, this uninit
structure member got tested, leading to some random allocator
behavior.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

I remember seeing this in Dave's:

        [UBER-PATCH, RFC] xfsprogs: sync libxfs to 3.8-rc2 kernel code

http://patchwork.xfs.org/patch/4683/

--Mark.

<Prev in Thread] Current Thread [Next in Thread>