xfs
[Top] [All Lists]

Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures
From: Eric Sandeen <esandeen@xxxxxxxxxx>
Date: Sun, 27 Jan 2013 21:41:28 -0500 (EST)
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130128003542.GB16727@xxxxxxxxxxxxxxxxxx>
References: <1359240032-11576-1-git-send-email-sandeen@xxxxxxxxxx> <1359240032-11576-3-git-send-email-sandeen@xxxxxxxxxx> <20130128003542.GB16727@xxxxxxxxxxxxxxxxxx>
On Jan 27, 2013, at 8:38 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:

> On Sat, Jan 26, 2013 at 04:40:26PM -0600, Eric Sandeen wrote:
>> This is a merge-to-userspace of kernel commit a0041684
>> xfs: zero allocation_args on the kernel stack
>> 
>> When calling xfs_alloc_vextent args.userdata was uninitialized,
>> and if we had args.type==XFS_ALLOCTYPE_START_BNO, this uninit
>> structure member got tested, leading to some random allocator
>> behavior.
> 
> Got that as part of the kernel-user sync I sent out a couple of
> weeks back.
> 
> BTW, perhaps we want to get that sync sorted out before shovelling
> a bunch of stuff into xfsprogs that will require fixing conflicts in
> that sync up?
> 
I have no problem with this going 2nd, I can fix up as needed.

-Eric

> Chers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>