[Top] [All Lists]

Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 28 Jan 2013 11:35:42 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1359240032-11576-3-git-send-email-sandeen@xxxxxxxxxx>
Mail-followup-to: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1359240032-11576-1-git-send-email-sandeen@xxxxxxxxxx> <1359240032-11576-3-git-send-email-sandeen@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Jan 26, 2013 at 04:40:26PM -0600, Eric Sandeen wrote:
> This is a merge-to-userspace of kernel commit a0041684
> xfs: zero allocation_args on the kernel stack
> When calling xfs_alloc_vextent args.userdata was uninitialized,
> and if we had args.type==XFS_ALLOCTYPE_START_BNO, this uninit
> structure member got tested, leading to some random allocator
> behavior.

Got that as part of the kernel-user sync I sent out a couple of
weeks back.

BTW, perhaps we want to get that sync sorted out before shovelling
a bunch of stuff into xfsprogs that will require fixing conflicts in
that sync up?


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>