xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: always take the iolock around xfs_setattr_size

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: always take the iolock around xfs_setattr_size
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 25 Jan 2013 16:53:18 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20121208121005.902710659@xxxxxxxxxxxxxxxxxxxxxx>
References: <20121208120812.755863148@xxxxxxxxxxxxxxxxxxxxxx> <20121208121005.902710659@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 12/08/12 06:08, Christoph Hellwig wrote:
There is no reason to conditionally take the iolock inside xfs_setattr_size
when we can let the caller handle it unconditionally, which just incrases
the lock hold time for the case where it was previously taken internally
by a few instructions.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

---
  fs/xfs/xfs_file.c     |    2 +-
  fs/xfs/xfs_iops.c     |   28 +++++++++++++++-------------
  fs/xfs/xfs_vnodeops.c |    3 +--
  fs/xfs/xfs_vnodeops.h |    2 +-
  4 files changed, 18 insertions(+), 17 deletions(-)

looks good

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 2/5] xfs: always take the iolock around xfs_setattr_size, Mark Tinguely <=