xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs: simplify the fallocate path

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfs: simplify the fallocate path
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 25 Jan 2013 11:32:41 -0600
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130104135638.GA16736@xxxxxxxxxxxxx>
References: <20121208120812.755863148@xxxxxxxxxxxxxxxxxxxxxx> <20121208121006.286014845@xxxxxxxxxxxxxxxxxxxxxx> <20121210020956.GN15784@dastard> <20121210105211.GA2794@xxxxxxxxxxxxx> <20130104135638.GA16736@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 01/04/13 07:56, Christoph Hellwig wrote:
On Mon, Dec 10, 2012 at 05:52:12AM -0500, Christoph Hellwig wrote:
On Mon, Dec 10, 2012 at 01:09:56PM +1100, Dave Chinner wrote:
You don't use this flag anywhere ;)

Fixed.

While I like most of this series, I don't really like the
duplication of this piece of code. It seems to me that a simple
helper like:

I had that in a previous version, but it seemed uglier than just
opencoding it.  I'll give it another try, maybe I can come up
with something nicer now.

I've looked at this and it does not seem to improve the code at all,
unless you have a strong objection I'm going to repost the series
just with the above unused variable removed.


ping?


--Mark.

<Prev in Thread] Current Thread [Next in Thread>