xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: make length of diff output configurable

To: David Sterba <dsterba@xxxxxxx>
Subject: Re: [PATCH v2] xfstests: make length of diff output configurable
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 23 Jan 2013 16:24:41 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1358939673-7523-1-git-send-email-dsterba@xxxxxxx>
References: <20130122214435.GM2498@dastard> <1358939673-7523-1-git-send-email-dsterba@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hi David,

On Wed, Jan 23, 2013 at 12:14:33PM +0100, David Sterba wrote:
> In commit 11c1d79414e2571 "xfstests: Change the diff output of failed
> tests", the diff output of a failed test was hardcoded to 10 lines to
> avoid overly long output and user can get the full output by manually
> running the diff. However this is not always possible and convenient,
> eg. in repeated automated tests where the required information is lost
> after the test round finished. Then the caputred logs do not contain
> enough informatin for analysis.

Ah, sorry for any inconvenience.

> Introduce the DIFF_LENGTH env variable to tune the diff size, keeping it
> 10 as deafult and 0 to disable the limit.
> 
> Signed-off-by: David Sterba <dsterba@xxxxxxx>

What you have here looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Regards,
        Ben

<Prev in Thread] Current Thread [Next in Thread>