xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfs: Fix possible use-after-free with AIO

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 2/4] xfs: Fix possible use-after-free with AIO
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 23 Jan 2013 16:00:04 -0600
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, tytso@xxxxxxx, jlbec@xxxxxxxxxxxx, xfs@xxxxxxxxxxx, stable@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1358945780-23661-3-git-send-email-jack@xxxxxxx>
References: <1358945780-23661-1-git-send-email-jack@xxxxxxx> <1358945780-23661-3-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jan 23, 2013 at 01:56:18PM +0100, Jan Kara wrote:
> Running AIO is pinning inode in memory using file reference. Once AIO
> is completed using aio_complete(), file reference is put and inode can
> be freed from memory. So we have to be sure that calling aio_complete()
> is the last thing we do with the inode.
> 
> CC: xfs@xxxxxxxxxxx
> CC: Ben Myers <bpm@xxxxxxx>
> CC: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Looks good!

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>