[Top] [All Lists]

Re: [PATCH] xfs: pull up stack_switch check into xfs_bmapi_write

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: pull up stack_switch check into xfs_bmapi_write
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 18 Jan 2013 10:31:09 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1358446289-871-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1358446289-871-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jan 17, 2013 at 01:11:29PM -0500, Brian Foster wrote:
> The stack_switch check currently occurs in __xfs_bmapi_allocate,
> which means the stack switch only occurs when xfs_bmapi_allocate()
> is called in a loop. Pull the check up before the loop in
> xfs_bmapi_write() such that the first iteration of the loop has
> consistent behavior.
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Yeah, that's a bug. As i mentioned on IRC, the backup copy of the
patch I have has these two hunks in it. Why they got dropped from
the primary copy is have no idea - perhaps it was an issue with
popping and pushing patches on and off my stack, and the hunks got
silently dropped...

I note that the port to the RHEL6 codebase has this correct - and
looking a the patch I ported it is the same as the backup copy in my
mainline guilt patch directory. So the intention was there that the
stack switch should have been moved, but it wasn't and the logic
problem wasn't picked up on review, so here we are...

Anyway, looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>