xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Change the diff output of failed tests

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Change the diff output of failed tests
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 17 Jan 2013 16:44:09 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <alpine.LFD.2.00.1204191038390.4508@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1334047113-32720-1-git-send-email-lczerner@xxxxxxxxxx> <alpine.LFD.2.00.1204191038390.4508@xxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Lukas,

On Thu, Apr 19, 2012 at 10:39:57AM +0200, Lukas Czerner wrote:
> On Tue, 10 Apr 2012, Lukas Czerner wrote:
> 
> > Currently the entire diff is printed to the stdout in the case that the
> > test output template differs from the actual test run. However in some
> > cases the diff can be _very_ long. This commit changes it so that we
> > print only first 10 lines of the diff.
> > 
> > Also indent the diff output from the left by four spaces for better
> > output readability.
> 
> ping

Saw this next to Eric's metadump patch.  Sorry to have missed it before.

Looks fine to me.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

This is commit 11c1d79.

-Ben

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfstests: Change the diff output of failed tests, Ben Myers <=