Hey Eric,
On Fri, Dec 14, 2012 at 01:55:30PM -0600, Alex Elder wrote:
> On 12/13/2012 08:56 PM, Eric Sandeen wrote:
> > On 4/9/12 11:34 PM, Eric Sandeen wrote:
> >> xfs_metadump currently obfuscates entire symlinks without regard
> >> to path components; this can lead to a corrupt image when restoring
> >> a metadump containing extremely long symlinks:
> >>
> >> Phase 3 - for each AG...
> >> - scan and clear agi unlinked lists...
> >> - process known inodes and perform inode discovery...
> >> - agno = 0
> >> component of symlink in inode 145 too long
> >> problem with symbolic link in inode 145
> >> cleared inode 145
> >> ... <more trail of woe>
> >>
> >> Fix this by consolidating symlink obfuscation into a new
> >> function which obfuscates one path component at a time.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> >
> > ping? :)
>
> You know, these things take time.
>
> What you have looks good to me, but I rewrote it, below. :)
>
> Even if you don't change anything...
>
> Reviewed-by: Alex Elder <elder@xxxxxxxxxxx>
Applied. This is commit b249a9f0.
Thanks,
Ben
|