xfs
[Top] [All Lists]

Re: [PATCH] xfstests: ensure all xfs_io commands are documented in the m

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: ensure all xfs_io commands are documented in the manpage
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 17 Jan 2013 14:38:17 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <50F816D1.1090806@xxxxxxx>
References: <50C39123.6050303@xxxxxxxxxxx> <50C3AA0F.4070505@xxxxxxxxxxx> <50F816D1.1090806@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 01/17/13 09:20, Mark Tinguely wrote:
On 12/08/12 14:58, Eric Sandeen wrote:
Ensure that all commands listed in "xfs_io -c help" are
documented in the xfs_io(8) manpage.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

diff --git a/293 b/293
new file mode 100755
index 0000000..e42344d
--- /dev/null
+++ b/293
@@ -0,0 +1,59 @@
+#! /bin/bash
+# FS QA Test No. 293
+#
+# Ensure all xfs_io commands are documented
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2012 Red Hat, Inc. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+#
+# creator
+owner=sandeen@xxxxxxxxxx
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+# real QA test starts here
+
+# Modify as appropriate.
+_supported_fs xfs
+_supported_os IRIX Linux
+
+echo "Silence is golden"
+
+for COMMAND in `$XFS_IO_PROG -c help | awk '{print $1}' | grep -v
"^Use "`; do


Can I remove the space in the "^Use " - The output still includes "Use":

xfs_io -c help | awk '{print $1}' | grep -v "^Use "

allocsp bmap chattr chproj close extsize fadvise falloc fdatasync fiemap
file fpunch freesp fsync help lsattr lsproj madvise mincore mmap mread
msync munmap mwrite open pread print pwrite quit resvsp sendfile stat
statfs sync_range truncate unresvsp zero Use

Otherwise it looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

xfstest 293 has been committed as 244295a

--Mark.

<Prev in Thread] Current Thread [Next in Thread>