xfs
[Top] [All Lists]

Re: [bisected] xfs panics when attempting to mount btrfs

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [bisected] xfs panics when attempting to mount btrfs
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 16 Jan 2013 17:39:04 -0600
Cc: Sergei Trofimovich <slyfox@xxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, Phil White <pwhite@xxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <50DF7CD1.90205@xxxxxxxxxxx>
References: <20121229135229.4ea4615a@xxxxxxxxxxxxx> <50DF508D.2010105@xxxxxxxxxxx> <20121230015109.1219d01f@sf> <50DF7CD1.90205@xxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Eric,

On Sat, Dec 29, 2012 at 05:29:21PM -0600, Eric Sandeen wrote:
> From: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> Do not return EFSCORRUPTED when filesystem probe finds no XFS magic
> 
> 9802182 changed the return value from EWRONGFS (aka EINVAL)
> to EFSCORRUPTED which doesn't seem to be handled properly by
> the root filesystem probe.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> - ---
> 
> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index da50846..7d6df7c 100644
> - --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -658,7 +658,7 @@ xfs_sb_quiet_read_verify(
>               return;
>       }
>       /* quietly fail */
> - -   xfs_buf_ioerror(bp, EFSCORRUPTED);
> +     xfs_buf_ioerror(bp, EWRONGFS);
>  }
>  
>  static void

Applied.

Thanks,
Ben

<Prev in Thread] Current Thread [Next in Thread>