[Top] [All Lists]

Re: [PATCH V2] xfsprogs: document all commands in xfs_io

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfsprogs: document all commands in xfs_io
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 16 Jan 2013 17:27:46 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <50F7352C.1090304@xxxxxxxxxxx>
References: <50C39123.6050303@xxxxxxxxxxx> <50C3A936.1050805@xxxxxxxxxxx> <50F4174A.3090709@xxxxxxx> <50F7352C.1090304@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 01/16/13 17:18, Eric Sandeen wrote:
On 1/14/13 8:33 AM, Mark Tinguely wrote:
On 12/08/12 14:55, Eric Sandeen wrote:
Add missing command documentation to xfs_io(8) manpage.
fiemap, fpunch, chproj, lsproj, and setfl are all missing.

setfl seems to not work today in any case, and nothing
in xfstests uses it; I will send another patch to simply
remove it from xfs_io, as I don't think it's terribly useful,
and hasn't worked forever anyway.

Also fix references to the fallocate manpage, which is (now?)
in section 2, not section 3 of the man pages.  (Since it's
a syscall, not a library function).

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxxx>

Looks good. Committed to xfsprogs as 83c324

Thanks.  Any plans to merge the other 3?

[PATCH] xfsprogs: remove setfl from xfs_io

 ^^^ have this ready to commit, just holding my breath in case
     someone wanted to have it fixed rather than removed.
     <play sound of crickets chirping>

[PATCH] xfsprogs: document fpunch command in xfs_io

 ^^^ Turns out to be superseded by the above patch.

[PATCH] xfstests: ensure all xfs_io commands are documented in the manpage

 ^^^ This one is ready, waiting for the setfl feature removal.

If I don't hear anything overnight, I will remove the setfl feature and
commit the new test.


<Prev in Thread] Current Thread [Next in Thread>