xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: remove setfl from xfs_io

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: remove setfl from xfs_io
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 15 Jan 2013 14:46:04 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <50C3AB0E.3050006@xxxxxxxxxxx>
References: <50C39123.6050303@xxxxxxxxxxx> <50C3AB0E.3050006@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 12/08/12 15:03, Eric Sandeen wrote:
Doesn't seem to have worked for ages, and is (therefore)
apparently not ever used:

xfs_io>  setfl
xfs_io>  help setfl
setfl [-adx] -- set/clear append/direct flags on the open file
xfs_io>  setfl -a
bad argument count 1 to setfl, expected 0 arguments
xfs_io>  setfl -d
bad argument count 1 to setfl, expected 0 arguments
xfs_io>  setfl
xfs_io>

At best, it seems intended to toggle the flag state, but
gives no feedback about current state.  -x is in help but
not implemented, etc.

Just remove it.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

I heard no objections to removing it ...

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>