xfs
[Top] [All Lists]

Re: [PATCH 1/1] fs/xfs remove obsolete simple_strto<foo>

To: Abhijit Pawar <abhi.c.pawar@xxxxxxxxx>
Subject: Re: [PATCH 1/1] fs/xfs remove obsolete simple_strto<foo>
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 11 Jan 2013 13:09:00 -0600
Cc: Jeff Liu <jeff.liu@xxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <50EFC356.10908@xxxxxxxxx>
References: <1357740282-2377-1-git-send-email-abhi.c.pawar@xxxxxxxxx> <50EFB2FE.2000307@xxxxxxxxxx> <50EFC356.10908@xxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey,

On Fri, Jan 11, 2013 at 01:16:30PM +0530, Abhijit Pawar wrote:
> On 01/11/2013 12:06 PM, Jeff Liu wrote:
> > On 01/09/2013 10:04 PM, Abhijit Pawar wrote:
> >> This patch replaces usages of obsolete simple_strtoul with kstrtoint in 
> >> xfs_args and suffix_strtoul.
> >>
> >> Signed-off-by: Abhijit Pawar <abhi.c.pawar@xxxxxxxxx>
> > checkpatch.pl show warning if we return EINVAL as below:
> > WARNING: return of an errno should typically be -ve (return -EINVAL)
> > 
> > Can we just ignore such code style issue?
> I think we can.
> Ben?

Yep, no worries.

Regards,
        Ben

<Prev in Thread] Current Thread [Next in Thread>