xfs
[Top] [All Lists]

Re: [PATCH 2/2 V3] xfstests: test EROFS vs. EEXIST when creating on an R

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2 V3] xfstests: test EROFS vs. EEXIST when creating on an RO filesystem
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 10 Jan 2013 10:50:26 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>
In-reply-to: <50ED9837.8040301@xxxxxxxxxxx>
References: <50B52DB7.3030506@xxxxxxxxxx> <50ED9726.4030008@xxxxxxxxxxx> <50ED9837.8040301@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 09, 2013 at 10:17:59AM -0600, Eric Sandeen wrote:
> TBH, I don't know if this is posix-specified, but I found out the
> hard way that when trying to re-create existing files on a readonly 
> filesystem, some apps expect/handle EEXIST, but fail on EROFS.
> 
> This will test mkdir, mknod, and symlinks for that behavior.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>