xfs
[Top] [All Lists]

Re: [PATCH] xfstests: move _filter_ln to common.filter

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: move _filter_ln to common.filter
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 10 Jan 2013 10:50:01 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>
In-reply-to: <50ED9726.4030008@xxxxxxxxxxx>
References: <50B52DB7.3030506@xxxxxxxxxx> <50ED9726.4030008@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 09, 2013 at 10:13:26AM -0600, Eric Sandeen wrote:
> Move test 103's _filter_ln to common.filter and make
> it more generic (not depending on 103's pathnames).
> 
> TBH I've lost my children's treasury of ln failure
> messages, so I'm not sure this catches all variants;
> it's hard to work backwards from the existing sed script
> to what the various outputs were.  This works for me
> but might need more tweaking on other systems.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>