xfs
[Top] [All Lists]

Re: [PATCH] xfs: stop using simple_strtoul()

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] xfs: stop using simple_strtoul()
From: Abhijit Pawar <abhi.c.pawar@xxxxxxxxx>
Date: Tue, 08 Jan 2013 21:07:38 +0530
Cc: Abhijit Pawar <abhi.c.pawar@xxxxxxxxx>, Jeff Liu <jeff.liu@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=E66/YkdZu5HG25+GdH7ob3m5VEF7Bz6gMyBAKOW1/LI=; b=c5unZjJMeVCKhGERMB0o/KNPW7zGQAY8rBynFS4uW8cWNsEpBnsJj439OYyAOCv2be hT9zRxqmYj/6vxR5uX5d2Scc7W1ZlshONgWStbp4qpfOMY1e3wIakTXEMyfakeJGjBKR g16CeLoc5ugvoleKhE26oonAfM9C1W4uigcpDeEkFVPSRTXuZhuTbmtZQGQo9HrJDqdq DvDv+S2TEg+NrcknPtNyXo64Iw17iwE6SsRGTV/YP+kycBXbgiFbcmGOKasc7ICpoi3T hCnBAPVHZ1GJaYW2ygNdwBdBWP4JFdyKHqcGxqgf7+xpog1ADBMRTartLtt4I9gW/tcX R3jg==
In-reply-to: <20130108153303.GO30652@xxxxxxx>
References: <50E8F470.5020305@xxxxxxxxxx> <20130107204957.GT27055@xxxxxxx> <50EBC8E5.9080200@xxxxxxxxxx> <50EC37FE.4010009@xxxxxxxxx> <20130108153303.GO30652@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
Hi Ben,
On 01/08/2013 09:03 PM, Ben Myers wrote:
> Hey Abhijit,
> 
> On Tue, Jan 08, 2013 at 08:45:10PM +0530, Abhijit Pawar wrote:
>> On 01/08/2013 12:51 PM, Jeff Liu wrote:
>>> On 01/08/2013 04:49 AM, Ben Myers wrote:
>>>> On Sun, Jan 06, 2013 at 11:50:08AM +0800, Jeff Liu wrote:
>>>>> This small patch convert xfs_parseargs() and suffix_strtoul() to
>>>>> use kstrtoint() instead of simple_strtoul() which is deprecated.
>>>>
>>>> It looks like Jeff's patch will conflict with a patch from Abhijit Pawar, 
>>>> 'fs:
>>>> remove obsolete simple_strto<foo>' which we saw Dec 7.  You guys went 
>>>> after the
>>>> same thing and came up with slightly differing results.  If Abhijit would
>>>> prefer to factor out the xfs changes I'd be happy to take either that, or
>>>> Jeff's patch, but it would be better if they didn't conflict.  Can y'all 
>>>> come
>>>> to an agreement as to what the xfs changes should be?
>>>
>>> Sorry, I missed that patch from Abhijit.
>>>
>>> Looks the previous patch did not replaced the simple_strtoul() with
>>> kstrtoint() in suffix_strtoul().
>>>
>>> Abhijit, would you like to fix it as well?
>>
>> Yes,it did not replace the call. Looks like I have missed that piece of
>> code. Once Ben applies my original patch, I will send another patch for
>> this on top of that.
> 
>       I believe that your original patch contains changes for other
> filesystems too.  I'd prefer to pull only xfs changes into the xfs branch.  
> Are
> you willing to factor out the xfs changes, add the suffix_strtoul, and resend?
> That way we can get it done in one go.
Yes. the patch contains changes to other filesystems as well. I will
separate out the xfs changes in a new patch and will also fix the
suffix_strtoul. I will send the patch soon.

> 
> Regards,
>       Ben
> 


-- 
-
Abhijit

<Prev in Thread] Current Thread [Next in Thread>