xfs
[Top] [All Lists]

Re: [PATCH] xfs: stop using simple_strtoul()

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] xfs: stop using simple_strtoul()
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 08 Jan 2013 15:21:09 +0800
Cc: Abhijit Pawar <abhi.c.pawar@xxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20130107204957.GT27055@xxxxxxx>
References: <50E8F470.5020305@xxxxxxxxxx> <20130107204957.GT27055@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2
Hi Ben and Abhijit,

On 01/08/2013 04:49 AM, Ben Myers wrote:
> Hey Jeff & Abhijit,
> 
> On Sun, Jan 06, 2013 at 11:50:08AM +0800, Jeff Liu wrote:
>> This small patch convert xfs_parseargs() and suffix_strtoul() to
>> use kstrtoint() instead of simple_strtoul() which is deprecated.
> 
> It looks like Jeff's patch will conflict with a patch from Abhijit Pawar, 'fs:
> remove obsolete simple_strto<foo>' which we saw Dec 7.  You guys went after 
> the
> same thing and came up with slightly differing results.  If Abhijit would
> prefer to factor out the xfs changes I'd be happy to take either that, or
> Jeff's patch, but it would be better if they didn't conflict.  Can y'all come
> to an agreement as to what the xfs changes should be?
Sorry, I missed that patch from Abhijit.

Looks the previous patch did not replaced the simple_strtoul() with
kstrtoint() in suffix_strtoul().

Abhijit, would you like to fix it as well?

Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>