[Top] [All Lists]

Re: [PATCH] xfs: stop using simple_strtoul()

To: Jeff Liu <jeff.liu@xxxxxxxxxx>, Abhijit Pawar <abhi.c.pawar@xxxxxxxxx>
Subject: Re: [PATCH] xfs: stop using simple_strtoul()
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 7 Jan 2013 14:49:57 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <50E8F470.5020305@xxxxxxxxxx>
References: <50E8F470.5020305@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Jeff & Abhijit,

On Sun, Jan 06, 2013 at 11:50:08AM +0800, Jeff Liu wrote:
> This small patch convert xfs_parseargs() and suffix_strtoul() to
> use kstrtoint() instead of simple_strtoul() which is deprecated.

It looks like Jeff's patch will conflict with a patch from Abhijit Pawar, 'fs:
remove obsolete simple_strto<foo>' which we saw Dec 7.  You guys went after the
same thing and came up with slightly differing results.  If Abhijit would
prefer to factor out the xfs changes I'd be happy to take either that, or
Jeff's patch, but it would be better if they didn't conflict.  Can y'all come
to an agreement as to what the xfs changes should be?


<Prev in Thread] Current Thread [Next in Thread>