xfs
[Top] [All Lists]

Re: [PATCH, v2] xfsdump: fix format string in restore_spec()

To: Alex Elder <elder@xxxxxxxxxxx>
Subject: Re: [PATCH, v2] xfsdump: fix format string in restore_spec()
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 4 Jan 2013 16:11:18 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <50DC56C6.5010607@xxxxxxxxxxx>
References: <50D7A1C2.9000609@xxxxxxxxxxxxxxx> <50DB794F.7010906@xxxxxxxxxxx> <50DC56C6.5010607@xxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Dec 27, 2012 at 08:10:14AM -0600, Alex Elder wrote:
> Nigel Tamplin reported getting a seg fault in xfsrestore when a path
> name was too long.  He correctly diagnosed that the problem was due
> to an extra "%s" format specifier in the format value passed to a
> call to mlog().  This patch corrects that.
> 
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxx>
> Reported-by: Nigel Tamplin <ntamplin@xxxxxxxxxxxxxxx>
> Tested-by: Nigel Tamplin <ntamplin@xxxxxxxxxxxxxxx>

Looks good!

committed to git://oss.sgi.com/xfs/cmds/xfsdump.git.

Thanks Nigel and Alex.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH, v2] xfsdump: fix format string in restore_spec(), Ben Myers <=