xfs
[Top] [All Lists]

Re: [PATCH] xfs: remove int casts from debug dquot soft limit timer asse

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: remove int casts from debug dquot soft limit timer asserts
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 3 Jan 2013 16:14:26 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1356104717-4722-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1356104717-4722-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Dec 21, 2012 at 10:45:17AM -0500, Brian Foster wrote:
> The int casts here make it easy to trigger an assert with a large
> soft limit. For example, set a >4TB soft limit on an empty volume
> to reproduce a (0 > -x) comparison due to an overflow of
> d_blk_softlimit.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

committed to git://oss.sgi.com/xfs/xfs.git master and for-next branches

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfs: remove int casts from debug dquot soft limit timer asserts, Ben Myers <=