Re: [PATCH] xfsdump: fill in missing strerror() call

xfs

Re: [PATCH] xfsdump: fill in missing strerror() call

To:	Alex Elder <elder@xxxxxxxxxxx>
Subject:	Re: [PATCH] xfsdump: fill in missing strerror() call
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 27 Dec 2012 02:44:10 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<50DB794F.7010906@xxxxxxxxxxx>
References:	<50D7A1C2.9000609@xxxxxxxxxxxxxxx> <50DB794F.7010906@xxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Dec 26, 2012 at 04:25:19PM -0600, Alex Elder wrote:
> Nigel Tamplin reported getting a seg fault in xfsrestore when a path
> name was too long.
> 
> Based on the surrounding code, I'm sure strerror(errno) was the
> intended final argument to this call.  This bug has been there
> since the code was first committed.

Seems like mlog needs an attribute marking it as printf-like.  
I'll see if I can come up with a patch for that.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
xfsrestore 3.1.2 segfaults when pathname too long for bind of UNIX domain socket, Nigel Tamplin [PATCH] xfsdump: fill in missing strerror() call, Alex Elder Re: [PATCH] xfsdump: fill in missing strerror() call, Nigel Tamplin Re: [PATCH] xfsdump: fill in missing strerror() call, Alex Elder Re: [PATCH] xfsdump: fill in missing strerror() call, Nigel Tamplin Re: [PATCH] xfsdump: fill in missing strerror() call, Christoph Hellwig <= Re: [PATCH] xfsdump: fill in missing strerror() call, Alex Elder [PATCH, v2] xfsdump: fix format string in restore_spec(), Alex Elder

Previous by Date:	Re: [PATCH] xfsdump: fill in missing strerror() call, Nigel Tamplin
Next by Date:	[PATCH, v2] xfsdump: fix format string in restore_spec(), Alex Elder
Previous by Thread:	Re: [PATCH] xfsdump: fill in missing strerror() call, Nigel Tamplin
Next by Thread:	Re: [PATCH] xfsdump: fill in missing strerror() call, Alex Elder
Indexes:	[Date] [Thread] [Top] [All Lists]