| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH] xfsdump: fill in missing strerror() call |
| From: | Alex Elder <elder@xxxxxxxxxxx> |
| Date: | Wed, 26 Dec 2012 16:25:19 -0600 |
| In-reply-to: | <50D7A1C2.9000609@xxxxxxxxxxxxxxx> |
| References: | <50D7A1C2.9000609@xxxxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Nigel Tamplin reported getting a seg fault in xfsrestore when a path
name was too long.
Based on the surrounding code, I'm sure strerror(errno) was the
intended final argument to this call. This bug has been there
since the code was first committed.
Signed-off-by: Alex Elder <elder@xxxxxxxxxxx>
Reported-by: Nigel Tamplin <ntamplin@xxxxxxxxxxxxxxx>
---
restore/content.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/restore/content.c b/restore/content.c
index edd00ed..4e55a76 100644
--- a/restore/content.c
+++ b/restore/content.c
@@ -7799,7 +7799,8 @@ restore_spec( filehdr_t *fhdrp, rv_t *rvp, char
*path )
"%s ino %llu %s: %s: discarding\n"),
printstr,
fhdrp->fh_stat.bs_ino,
- path );
+ path,
+ strerror( errno ));
( void )close( sockfd );
return BOOL_TRUE;
}
--
1.7.9.5
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Rüsten Sie Ihre E-Mail Jetzt, Email Help Desk |
|---|---|
| Next by Date: | Re: [PATCH] xfsdump: fill in missing strerror() call, Nigel Tamplin |
| Previous by Thread: | xfsrestore 3.1.2 segfaults when pathname too long for bind of UNIX domain socket, Nigel Tamplin |
| Next by Thread: | Re: [PATCH] xfsdump: fill in missing strerror() call, Nigel Tamplin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |