xfs
[Top] [All Lists]

Re: [PATCH, -stable RFC] xfs: fix periodic log flushing

To: Andre Noll <maan@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH, -stable RFC] xfs: fix periodic log flushing
From: Matthias Schniedermeyer <ms@xxxxxxx>
Date: Wed, 19 Dec 2012 02:31:41 +0100
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121219002145.GK31273@xxxxxxxxxxxxxxx>
References: <20121218221616.GH15182@dastard> <20121218224022.GJ31273@xxxxxxxxxxxxxxx> <20121218232533.GJ15182@dastard> <20121219002145.GK31273@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On 19.12.2012 01:21, Andre Noll wrote:
> On Wed, Dec 19, 10:25, Dave Chinner wrote:
> > AFAIK 3.6 is still being updated - 3.6.11 was tagged only 29 hours ago.
> 
> Quoting from the 3.6.11 release announcement:
> 
>       Note, this is the LAST kernel in the 3.6.y series, it is
>       now end-of-life.  Please move to the 3.7.y kernel series at
>       this time.
> 
> > I probably should also mention in the commit message that there is
> > no equivalent upstream fix, as the fix in 3.8 is part of a complete
> > reworking of the code and hence not appropriate for backporting
> > to -stable.
> 
> Definitely. Greg tends to get grumpy when he is asked to apply a
> patch for the stable series that has no counterpart upstream :)
> 
> > > > -       if (!(mp->m_super->s_flags & MS_ACTIVE) &&
> > > 
> > > appears to be in the longterm kernels 3.2.35 and 3.4.24 as well (it
> > > was changed in commit 1307bbd which got reverted in 11159a05). Are
> > > these kernels also affected?
> > 
> > I have no idea - I don't track them, don't test them and haven't
> > tried to reproduce the problem on them.
> > 
> > If you want to support all the stable trees, you're welcome to do
> > all this, but it's not something I care to do. We have reports of
> > this problem on 3.5 to 3.7 and the patch applies to all three
> > kernels, so that's as far as I care right now....
> 
> Understood. Personally, I only care about 3.4 as this is the kernel we
> are running on most of our production systems. Would you be willing
> to submit the patch also for 3.4-stable if Matthias or myself
> reproduced the issue on 3.4 and confirmed that the patch fixes the
> problem there as well?

I only have my personal machines to care about and they are a mix of 3.7 
and 3.7.1(+patch) ATM.

And i'd say you only have to grep for the line to see if a kernel is 
buggy. Altough testing for the bug is relativly simpel too.

Just make a loop that 'dd's a few files files into a (fresh) 
sub-directory on a USB-disc and yank out the cable after a minute (or a 
usb-stick and yank that out), a power-failure would work too. The bug 
hits regardless of the files beeing written or after the activity has 
already ceased. As long as you don't do anything else inbetween you can 
see some or all files are missing after reconnecting the disc.





-- 

Matthias

<Prev in Thread] Current Thread [Next in Thread>