xfs
[Top] [All Lists]

Re: [PATCH, -stable RFC] xfs: fix periodic log flushing

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH, -stable RFC] xfs: fix periodic log flushing
From: Andre Noll <maan@xxxxxxxxxxxxxxx>
Date: Tue, 18 Dec 2012 23:40:22 +0100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121218221616.GH15182@dastard>
References: <20121218221616.GH15182@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Dec 19, 09:16, Dave Chinner wrote:
> There is a logic inversion in xfssyncd_worker() which means that the
> log is not periodically forced or idled correctly. This means that
> metadata changes aggregated in memory do not get flushed in a timely
> manner, and hence if filesystem is not cleanly unmounted those
> changes can be lost. This loss can manifest itself even hours after
> the changes were made if the filesystem is left to idle without a
> sync() occurring between the last modification and the
> crash/shutdown occuring.
> 
> cc: <stable@xxxxxxxxxxxxxx> # 3.7, 3.6, 3.5

As 3.5 and 3.6 are end of life, Greg will probably apply this only
to 3.7. Also, the problematic line,

> -     if (!(mp->m_super->s_flags & MS_ACTIVE) &&

appears to be in the longterm kernels 3.2.35 and 3.4.24 as well (it
was changed in commit 1307bbd which got reverted in 11159a05). Are
these kernels also affected?

Thanks
Andre
-- 
The only person who always got his work done by Friday was Robinson Crusoe

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>