xfs
[Top] [All Lists]

Re: [PATCH] Use qa_user and qa_group for test 219

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] Use qa_user and qa_group for test 219
From: Jan Kara <jack@xxxxxxx>
Date: Tue, 18 Dec 2012 18:50:06 +0100
Cc: Jan Kara <jack@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <50D071BE.20000@xxxxxxxxxx>
References: <1355830435-5942-1-git-send-email-jack@xxxxxxx> <50D071BE.20000@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue 18-12-12 08:38:06, Brian Foster wrote:
> On 12/18/2012 06:33 AM, Jan Kara wrote:
> > Test 219 requires a special user. Use $qa_user and $qa_group (added in this
> > patch) for that purpose instead of hardcoded uid & gid. This also fixes
> > a false failure when repquota does not report quota for users not in passwd.
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > ---
> ...
> > +# check for the fsgqa group on the machine
> > +#
> > +_require_group()
> > +{
> > +    qa_group=fsgqa
> > +    _cat_group | grep -q $qa_user
> > +    [ "$?" == "0" ] || _notrun "$qa_user user not defined."
> 
> I assume you mean to use $qa_group instead of $qa_user in the above two
> lines?
  Bah, right. The names are the same so I didn't notice my copy-and-paste
mistake :). Fixed version attached.

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

Attachment: 0001-Use-qa_user-and-qa_group-for-test-219.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>