xfs
[Top] [All Lists]

Re: dmapi: update version to 2.2.12

To: xfs@xxxxxxxxxxx
Subject: Re: dmapi: update version to 2.2.12
From: Alex Elder <elder@xxxxxxxxxxx>
Date: Thu, 13 Dec 2012 14:43:04 -0600
In-reply-to: <20121213201354.GP30652@xxxxxxx>
References: <20121213201354.GP30652@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
On 12/13/2012 02:13 PM, Ben Myers wrote:
> Update the version number to 2.2.12 and update release.sh script to work
> with newer versions of git.
> 
> Signed-off-by: Ben Myers <bpm@xxxxxxx>

Looks good.  I have a suggestion below (applies to all of
the user space trees).

Reviewed-by: Alex Elder <elder@xxxxxxxxxxx>

> ---
>  VERSION      |    2 +-
>  configure.ac |    2 +-
>  doc/CHANGES  |    3 +++
>  release.sh   |    2 +-
>  4 files changed, 6 insertions(+), 3 deletions(-)
> 
> Index: b/VERSION
> ===================================================================
> --- a/VERSION 2012-12-13 13:33:28.391319152 -0600
> +++ b/VERSION 2012-12-13 13:33:29.861323243 -0600
> @@ -3,5 +3,5 @@
>  #
>  PKG_MAJOR=2
>  PKG_MINOR=2
> -PKG_REVISION=11
> +PKG_REVISION=12
>  PKG_BUILD=1
> Index: b/configure.ac
> ===================================================================
> --- a/configure.ac    2012-12-13 13:33:28.391319152 -0600
> +++ b/configure.ac    2012-12-13 13:33:29.861323243 -0600
> @@ -1,4 +1,4 @@
> -AC_INIT([dmapi], [2.2.11])
> +AC_INIT([dmapi], [2.2.12])

Is there any way this can be edited automatically by the
release.sh script, so it's guaranteed to match the version
number encoded in VERSION?  Sort of like what's done for
the CHANGES file, perhaps.

>  
>  AC_PREREQ(2.50)
>  AC_CONFIG_AUX_DIR([.])
> Index: b/doc/CHANGES
> ===================================================================
> --- a/doc/CHANGES     2012-12-13 13:33:28.391319152 -0600
> +++ b/doc/CHANGES     2012-12-13 13:33:29.911319898 -0600
> @@ -1,3 +1,6 @@
> +dmapi-2.2.12 (13 Dec 2012)
> +     - Updated the release.sh script to work with newer git.
> +
>  dmapi-2.2.11 (31 Oct 2012)
>       - Various build related fixes, thanks to Theodore Ts'o,
>         Mike Frysinger, and Jan Engelhardt
> Index: b/release.sh
> ===================================================================
> --- a/release.sh      2012-12-13 13:33:28.391319152 -0600
> +++ b/release.sh      2012-12-13 13:33:29.941320681 -0600
> @@ -13,7 +13,7 @@ sed -e "s/${version}.*/${version} (${dat
>       mv doc/CHANGES.tmp doc/CHANGES
>  
>  echo "Commiting CHANGES update to git"
> -git-commit -s -a -m "${version} release"
> +git commit -s -a -m "${version} release"
>  
>  echo "Tagging git repository"
>  git tag -s -a -m "${version} release" v${version}
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>