[Top] [All Lists]

Re: [PATCH v3 0/5] discontiguous buffer patches

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH v3 0/5] discontiguous buffer patches
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 13 Dec 2012 11:31:22 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121204231801.982422341@xxxxxxx>
References: <20121204231801.982422341@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 04, 2012 at 05:18:01PM -0600, Mark Tinguely wrote:
> Eric Sundeen's "userspace vs. fragmented multiblock dir2", xfstest 291
> commit 2a4ed, causes a xfs_buf lock hang:
> [<ffffffff81065d87>] down+0x47/0x50
> [<ffffffffa03a25c6>] xfs_buf_lock+0x66/0xe0 [xfs]
> [<ffffffffa03a33c9>] _xfs_buf_find+0x1f9/0x320 [xfs]
> [<ffffffffa03a393f>] xfs_buf_get_map+0x2f/0x170 [xfs]
> [<ffffffffa03a3f7a>] xfs_buf_read_map+0x2a/0x100 [xfs]
> [<ffffffffa0411630>] xfs_trans_read_buf_map+0x3b0/0x590 [xfs]
> [<ffffffffa03e1c5e>] xfs_da_read_buf+0xbe/0x230 [xfs]
> [<ffffffffa03e78dc>] xfs_dir2_block_addname+0x7c/0x980 [xfs]
> [<ffffffffa03f1468>] xfs_dir2_sf_addname+0x3e8/0x450 [xfs]
> [<ffffffffa03e634c>] xfs_dir_createname+0x17c/0x1e0 [xfs]
> [<ffffffffa03b9fe2>] xfs_create+0x4c2/0x5f0 [xfs]
> [<ffffffffa03b0c8a>] xfs_vn_mknod+0x8a/0x1a0 [xfs]
> [<ffffffffa03b0dce>] xfs_vn_create+0xe/0x10 [xfs]
> [<ffffffff8115695c>] vfs_create+0xac/0xd0
> [<ffffffff811587de>] do_last+0x8be/0x960
> [<ffffffff8115940c>] path_openat+0xdc/0x410
> [<ffffffff81159853>] do_filp_open+0x43/0xa0
> [<ffffffff8114a502>] do_sys_open+0x152/0x1e0
> [<ffffffff8114a5cc>] sys_open+0x1c/0x20
> [<ffffffff81423df9>] system_call_fastpath+0x16/0x1b
> [<ffffffffffffffff>] 0xffffffffffffffff
> Changes to the series from version 2:
> Patch 2: The renaming of b_map to __b_map is in its own patch.
> Patch 3: The buffer log format assert is in its own patch and simplies the
>        initialization per Dave's suggestion.
> Patch 5: The XFS_TRANS_DEBUG is completely removed from xfs.

I think the whole series looks good as it is and hasn't caused my
testing any problems. We can address the XFS_BLI_DIRTY issues

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>