xfs
[Top] [All Lists]

Re: [PATCH] mkfs.xfs: don't detect geometry values <= physblk size

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] mkfs.xfs: don't detect geometry values <= physblk size
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 13 Dec 2012 10:16:42 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <50C9093C.8080400@xxxxxxxxxx>
References: <50C9093C.8080400@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 12, 2012 at 04:46:20PM -0600, Eric Sandeen wrote:
> blkid_get_topology() ignores devices which report 512
> as their minimum & optimal IO size, but we should ignore
> anything up to the physical block size; otherwise
> 4k devices will report a "stripe size" of 4k, and warn
> if anything larger is specified:

As i read this, I thought no, that's wrong, it should read
"we should ignore anything up to the sector size". I had to read the
code to find out that's exactly what the change does.

Perhaps you should be talking about sector sizes here?

> -      * If the reported values are just the normal 512 byte block size
> -      * do not bother to report anything.  It will just causes warnings
> -      * if people specifier larger stripe units or widths manually.
> +      * If the reported values are the same as the physical block size

"... same as the sector size of the device ...."

Otherwise seems sane...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>