| To: | Mark Tinguely <tinguely@xxxxxxx> |
|---|---|
| Subject: | Re: [3.0-stable PATCH 27/36] xfs: protect xfs_sync_worker with s_umount semaphore |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 12 Dec 2012 10:52:23 +1100 |
| Cc: | stable@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20121203144311.307692292@xxxxxxx> |
| References: | <20121203144208.143464631@xxxxxxx> <20121203144311.307692292@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Dec 03, 2012 at 05:42:35PM -0600, Mark Tinguely wrote: > From: Ben Myers <bpm@xxxxxxx> > > Upstream commit: 1307bbd2af67283131728637e9489002adb26f10 > > xfs_sync_worker checks the MS_ACTIVE flag in s_flags to avoid doing > work during mount and unmount. This flag can be cleared by unmount > after the xfs_sync_worker checks it but before the work is completed. > The has caused crashes in the completion handler for the dummy > transaction commited by xfs_sync_worker: This doesn't belong in a stable kernel. It was wrong when it was originally committed, it's wrong to backport it. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [3.0-stable PATCH 21/36] xfs: Dont allocate new buffers on every call to _xfs_buf_find, Dave Chinner |
|---|---|
| Next by Date: | Re: [3.0-stable PATCH 30/36] xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near, Dave Chinner |
| Previous by Thread: | [3.0-stable PATCH 27/36] xfs: protect xfs_sync_worker with s_umount semaphore, Mark Tinguely |
| Next by Thread: | [3.0-stable PATCH 03/36] xfs: mark the xfssyncd workqueue as non-reentrant, Mark Tinguely |
| Indexes: | [Date] [Thread] [Top] [All Lists] |