xfs
[Top] [All Lists]

Re: [3.0-stable PATCH 17/36] xfs: punch new delalloc blocks out of faile

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [3.0-stable PATCH 17/36] xfs: punch new delalloc blocks out of failed writes inside EOF.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 12 Dec 2012 10:47:03 +1100
Cc: stable@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20121203144310.380163216@xxxxxxx>
References: <20121203144208.143464631@xxxxxxx> <20121203144310.380163216@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 03, 2012 at 05:42:25PM -0600, Mark Tinguely wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Upstream commit: d3bc815afb549eecb3679a4b2f0df216e34df998
> 
> When a partial write inside EOF fails, it can leave delayed
> allocation blocks lying around because they don't get punched back
> out. This leads to assert failures like:
> 
> XFS: Assertion failed: XFS_FORCED_SHUTDOWN(ip->i_mount) || ip->i_delayed_blks 
> == 0, file: fs/xfs/linux-2.6/xfs_super.c, line: 847

This is something that makes me worried. It's complex enough that
I've forgotten all the nasty little things it took to get this right
when I originally wrote it, and we have very little test
coverage/verification of this error case in xfstests. Did you do
anything other than run xfstests to verify this code is working
properly?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>