xfs
[Top] [All Lists]

Re: [3.0-stable PATCH 12/36] xfs: dont fill statvfs with project quota f

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [3.0-stable PATCH 12/36] xfs: dont fill statvfs with project quota for a directory
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 12 Dec 2012 10:38:10 +1100
Cc: stable@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20121203144309.930913286@xxxxxxx>
References: <20121203144208.143464631@xxxxxxx> <20121203144309.930913286@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 03, 2012 at 05:42:20PM -0600, Mark Tinguely wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Upstream commit: da5bf95e3cdca348327c82568c2860229c0daaa2
>  if it was not enabled.
> 
> Check if the project quota is running or not before performing
> xfs_qm_statvfs(), just return if not.  Otherwise the ASSERT
> XFS_IS_QUOTA_RUNNING in xfs_qm_dqget will be popped.

On production kernels, it will just return immediately because the
next checks are for whether quota is enabled. Hence this is fixing
a debug only problem, so doesn't really seem like a -stable
candidate to me...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>