xfs
[Top] [All Lists]

Re: [3.0-stable PATCH 09/36] xfs: Fix open flag handling in open_by_hand

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [3.0-stable PATCH 09/36] xfs: Fix open flag handling in open_by_handle code
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 12 Dec 2012 10:35:38 +1100
Cc: stable@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20121203144309.644469343@xxxxxxx>
References: <20121203144208.143464631@xxxxxxx> <20121203144309.644469343@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 03, 2012 at 05:42:17PM -0600, Mark Tinguely wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Upstream commit: 1a1d772433d42aaff7315b3468fef5951604f5c6
> 
> Sparse identified some unsafe handling of open flags in the xfs open
> by handle ioctl code. Update the code to use the correct access
> macros to ensure that we handle the open flags correctly.

This isn't really fixing a bug. The code was not actually broken,
just old and warning about a potential problem. Hence I don't see
this as a stable candidate...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>